Changes between Version 4 and Version 5 of CodingStyle

Timestamp:

Jun 19, 2016, 4:35:19 PM (8 years ago)

Author:

Gabriele Pohl

Comment:

Some hints from Christian Franke on coding style

CodingStyle

@@ -39 +39 @@
 unsigned char offl_pending_id;          // ID of offline uncorrectable sector count, 0 if none
 }}}
+
+=== Some Hints ===
+
+A snippet cut out of a mail from Christian Franke on developers list..
+
+Due to its long history, many contributors and late move from C to C++, smartmontools is in fact a mixture of different coding styles. 
+
+In my recent additions I used (or tried to use) the following for new code:
+
+{{{
+Naming:
+lowercase_underline_lowercase (like C++ std::)
+
+Indentation:
+2 Blanks, no tab characters
+
+No extra indentation level for {...} blocks
+
+No extra line for '{' except for the function body.
+
+Lokal variables:
+C++/C99 declaration statements: First use=declaration=initialization
+(I really dislike traditional C style with all decls at the beginning of a block :-)
+
+Null pointers:
+"Stroustrup Style": 0 instead of NULL,
+(T *)0 if needed or compiler check is desired.
+
+Checks in boolean style: if (p) ; if (!p) ;
+
+In comments: "nullptr" (forward compatible to C++0x :-)
+
+Exceptions:
+Avoid any try/catch blocks if possible, use RAII instead
+}}}