Opened 7 years ago

Closed 6 years ago

Last modified 5 years ago

#956 closed enhancement (fixed)

add to existing drivedb entry: ST1000NM0055

Reported by: Stefan Owned by:
Priority: minor Milestone: Release 7.0
Component: drivedb Version:
Keywords: Cc:

Description

Hello,

today I tested trunk 4648 and the json output. I tested it with a Seagate ST1000NM0055-1V410C and get a json-output like
"in_smartctl_database" : false,
but when i looking in https://www.smartmontools.org/browser/trunk/smartmontools/drivedb.h for 'ST1000NM0055' i found it, maybe there is some problems with drivedb-checks?

btw: if you need help with json output I've SATA-HDD, SAS-HDD/SSD to help you with the output

Attachments (1)

smartctl-Seagate-ST1000NM0055-1V410C.txt (13.5 KB ) - added by Stefan 7 years ago.
smartctl -x output, to complete recommendations to add a drive to the drivedb

Download all attachments as: .zip

Change History (6)

comment:1 by Christian Franke, 7 years ago

Thanks for testing.

JSON output of in_smartctl_database is correct. The drive is listed in a comment above the drivedb entry, but accidentally its regex does not match ST1000NM0055 :

$ smartctl -P showall 'ST1000NM0055-1V410C'
No presets are defined for this drive.  Its identity strings:
MODEL:    ST1000NM0055-1V410C
FIRMWARE: (any)
do not match any of the known regular expressions.

$ smartctl -P showall 'ST2000NM0045-1V410C'
Drive found in smartmontools Database.  ...
MODEL FAMILY:       Seagate Enterprise Capacity 3.5 HDD
...

Of course, future test reports for JSON output are appreciated.

BTW: To compare old/json output, try smartctl --json=i.

comment:2 by Christian Franke, 7 years ago

Component: alldrivedb
Keywords: json drivedb removed
Milestone: Release 6.7
Priority: trivialminor
Summary: json output 'in_smartctl_database' maybe wrong?add to existing drivedb entry: ST1000NM0055
Type: defectenhancement

Changing ticket summary accordingly.

by Stefan, 7 years ago

smartctl -x output, to complete recommendations to add a drive to the drivedb

comment:3 by Alex Samorukov, 6 years ago

Resolution: fixed
Status: newclosed

Fixed in r4708.

comment:4 by Christian Franke, 6 years ago

Merged in r4719.

comment:5 by Christian Franke, 5 years ago

Milestone: Release 6.7Release 7.0

Milestone renamed

Note: See TracTickets for help on using tickets.