Opened 9 years ago

Closed 2 years ago

#93 closed defect (wontfix)

os_linux.cpp: Use SG_IO instead of deprecated SCSI ioctl

Reported by: Christian Franke Owned by: somebody
Priority: major Milestone:
Component: all Version: 5.39.1
Keywords: linux Cc:

Description

Some controller specific functions in os_linux.cpp still use some old SCSI pass-through ioctl. This may result in syslog messages like:

... kernel: [...] program smartd is using a deprecated SCSI ioctl, please convert it to SG_IO

SG_IO should be used if supported.

Change History (5)

comment:1 Changed 4 years ago by Christian Franke

Milestone: unscheduled

comment:2 Changed 2 years ago by Alex Samorukov

See #782 for the patch

comment:3 Changed 2 years ago by Alex Samorukov

Places affected:

  1. SCSI_IOCTL_SEND_COMMAND in the sisc_cmnd_io, using linux_ioctl_send_command structure, called only from do_normal_scsi_cmnd_io, should be addressed by #782.
  2. In the linux_escalade_device::ata_pass_through (using TW_Ioctl structure)
  3. In the linux_marvell_device::ata_command_interface (sending mvsata_scsi_cmd structure)

I think that it would be hard, if possible to fix 2 and 3, because we do not have access to this hardware. So i think we can close it after merging #782.

Last edited 2 years ago by Alex Samorukov (previous) (diff)

comment:4 Changed 2 years ago by Christian Franke

  1. Was not intended to be addressed by this ticket as the generic SCSI code already used SG_IO if supported.
  2. SCSI_IOCTL_SEND_COMMAND is only used if m_escalade_type==AMCC_3WARE_678K for very old 3ware (6|7|8)000 (P|P|S)ATA RAID controllers.
  3. If have no idea whether -d marvell does still work and is still useful (see also #54). Original code was merged to trunk 13+ years ago in r1881. Related hardware is likely outdated.

comment:5 Changed 2 years ago by Christian Franke

Milestone: unscheduled
Resolution: wontfix
Status: newclosed

Related hardware is outdated and unavailable.

Note: See TracTickets for help on using tickets.