Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#889 closed patch (fixed)

Patch for syntax error in drivedb.h revision 4474

Reported by: Cmdr_Zod Owned by: Alex Samorukov
Priority: major Milestone: Release 6.6
Component: drivedb Version: 6.5
Keywords: Cc:

Description (last modified by Alex Samorukov)

Just wanted to try out the newest revision of the drivedb.h and failed with a syntax error on line 3168:
/var/lib/smartmontools/drivedb/drivedb.h(3168): Syntax error, ',' expected

This patch should fix the bug:

--- drivedb.h.4474      2017-09-23 15:40:30.000000000 +0200
+++ drivedb.h.fixed     2017-09-24 01:52:55.064034496 +0200
@@ -3162,7 +3162,7 @@
   // should be ST4000DM005, ST3000DM008,ST3000DM009,ST2000DM006,ST2000DM007
   // ST1000DM010, ST500DM009
   { "Seagate Barracuda 3.5", // tested on ST1000DM010-2EP102/Z9ACZM97
-    "ST(4000DM005|3000DM008|3000DM009|2000DM006|2000DM007)-"
+    "ST(4000DM005|3000DM008|3000DM009|2000DM006|2000DM007)-",
     "", "",
     "-v 188,raw16 -v 240,msec24hour32"
   },

Change History (5)

comment:1 Changed 6 years ago by Alex Samorukov

Description: modified (diff)
Owner: set to Alex Samorukov
Status: new → assigned

comment:2 Changed 6 years ago by Alex Samorukov

Resolution: → fixed
Status: assigned → closed

Fixed in r4475, thank you for the report.

comment:3 Changed 6 years ago by Alex Samorukov

Description: modified (diff)

comment:4 Changed 6 years ago by Christian Franke

Milestone: → Release 6.6

comment:5 Changed 6 years ago by Christian Franke

Merged in r4490.

Note: See TracTickets for help on using tickets.