Opened 2 years ago

Closed 2 years ago

#874 closed patch (fixed)

SK hynix SC210, SC300, SC308, SC313 HFS256G32TNF-N3A0A

Reported by: Brij Kishore Rai Owned by:
Priority: minor Milestone: Release 6.6
Component: drivedb Version: 6.5
Keywords: Cc:

Description

Hello Smartctl Drive Database Team,

I found that my companies SSD drive (Project Name: SC313) has some attribute with different definition then default so I created a new entry for them. Please find attached my modified drivedb.h and output file.

Please update the current database.

Thanks,
Brij

Attachments (9)

smartctl-SK hynix SC313 HFS256G32TNF-N3A0A.txt (19.1 KB) - added by Brij Kishore Rai 2 years ago.
Updated Database file
smartctl-HFS500G32TND-N1A2A.txt (5.3 KB) - added by Brij Kishore Rai 2 years ago.
SC308 log
smartctl-SKhynix SC300 HFS256G32MND-3210A.txt (5.0 KB) - added by Brij Kishore Rai 2 years ago.
SC300 log
drivedb.2.h (159.9 KB) - added by Brij Kishore Rai 2 years ago.
Updated Database file
drivedb.3.h (159.9 KB) - added by Brij Kishore Rai 2 years ago.
Updated Database file
drivedb.h (159.9 KB) - added by Brij Kishore Rai 2 years ago.
Updated Database file
SC313_with_4490.txt (6.2 KB) - added by Brij Kishore Rai 2 years ago.
output with r4490
SC313_with_patch.txt (6.2 KB) - added by Brij Kishore Rai 2 years ago.
Output with applied patch
drivedb.h.patch (1.6 KB) - added by Brij Kishore Rai 2 years ago.
drivedb.h r4490 patch

Download all attachments as: .zip

Change History (21)

Changed 2 years ago by Brij Kishore Rai

Updated Database file

comment:1 Changed 2 years ago by Christian Franke

Component: alldrivedb
Keywords: SK hynix removed
Milestone: Release 6.6
Type: defectenhancement

comment:2 Changed 2 years ago by Christian Franke

Thanks.

I found that my companies SSD drive ...

Could you possibly also provide info or patches for other SK hynix SSD series?

For example SC210 (ticket #724) or SC308 (ticket #792).

comment:3 Changed 2 years ago by Brij Kishore Rai

Hi Chris,

I was able to find SC210 (ticket #724), SC300 & SC308(ticket #792) drive and it's SMART implementation details.

Uploading the updated database file & tested logs. Patch is on top of smartctl 6.6 2017-08-08 r4433 build.

Thanks,
Brij

Changed 2 years ago by Brij Kishore Rai

SC308 log

Changed 2 years ago by Brij Kishore Rai

SC300 log

Changed 2 years ago by Brij Kishore Rai

Attachment: drivedb.2.h added

Updated Database file

Changed 2 years ago by Brij Kishore Rai

Attachment: drivedb.3.h added

Updated Database file

Changed 2 years ago by Brij Kishore Rai

Attachment: drivedb.h added

Updated Database file

comment:4 Changed 2 years ago by Alex Samorukov

Resolution: fixed
Status: newclosed

Done, in r4451, thank you.

comment:5 Changed 2 years ago by Christian Franke

Merged in r4490.

comment:6 Changed 2 years ago by Brij Kishore Rai

Hi Chris,

I tested the updated database file and found that it didn't work as per my expectation.

Please refer

  1. the output with r4490 and with my patch.
    1. SC313_with_4490.txt
    2. SC313_with_patch.txt
  2. I have create a patch file from working copy on top of r4490 (drivedb.h.patch)

Thanks,
Brij

Changed 2 years ago by Brij Kishore Rai

Attachment: SC313_with_4490.txt added

output with r4490

Changed 2 years ago by Brij Kishore Rai

Attachment: SC313_with_patch.txt added

Output with applied patch

comment:7 Changed 2 years ago by Brij Kishore Rai

Resolution: fixed
Status: closedreopened

Hi Chris,

I re-opened the ticket and also provided suggested patch. Please help getting this fixed.

Thanks,
Brij

comment:8 Changed 2 years ago by Alex Samorukov

Thank you for the feedback.

(.*SK hynix SC.*|"
".*SKhynix SC.*)",

Could be replaces with

.*SK ?hynix SC.*

But what really makes me unhappy is that if your company will ever release disk with a different SMART but same model name - it will fail. So let me check why original patch was not working.

comment:9 Changed 2 years ago by Alex Samorukov

Also this patch will break HFS512G32MND model

comment:10 Changed 2 years ago by Brij Kishore Rai

Hi Chris,

Patch r4490 didn't worked on SC313 drive due to the missing space as 3rd character (space) in the model number. and also it creates a partial match with drives model number.

instead of

"SKhynix SC(300|313)"

it needs to be

"SK hynix SC(300|313).*"

and also can be merged with another string

"SK hynix SC(210|308)|"

as

"SK ?hynix SC(210|300|308|313).*"

and may another concern was all the attribute wherein SK hynix drive differs where not included int r4490 patch.

So, I update my working code based on your suggestion and what I found missing.

Let me know your thought.

Regards,
Brij

Changed 2 years ago by Brij Kishore Rai

Attachment: drivedb.h.patch added

drivedb.h r4490 patch

comment:11 Changed 2 years ago by Christian Franke

Summary: SK hynix SC313 HFS256G32TNF-N3A0ASK hynix SC210, SC300, SC308, SC313 HFS256G32TNF-N3A0A
Type: enhancementpatch

Tickets #724 and #792 have been marked as duplicates of this ticket.

comment:12 Changed 2 years ago by Christian Franke

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.