Support nvme nvd device IDs

[cpuroast]

As per: ​https://www.freebsd.org/cgi/man.cgi?query=nvd

The nvd driver exposes NVM Express (NVMe) namespaces as disks to the kernel disk storage API

Device nodes from the nvd driver will have the format /dev/nvdX

smartctl -a /dev/nvd0

/dev/nvd0: Unable to detect device type
Please specify device type with the -d option.

smartctl -a /dev/nvd0 -d nvme

Smartctl open device: /dev/nvd0 failed: NVMe controller controller/namespace ids must begin with '/dev/nvme'

smartctl -a /dev/nvme0

=== START OF INFORMATION SECTION ===
Model Number:                       INTEL SSDPEDMD400G4
Serial Number:                      CVFT5343004C400BGN
Firmware Version:                   8DV10171
PCI Vendor/Subsystem ID:            0x8086
IEEE OUI Identifier:                0x5cd2e4
Controller ID:                      0
Number of Namespaces:               1
Namespace 1 Size/Capacity:          400,088,457,216 [400 GB]
Namespace 1 Formatted LBA Size:     512
Local Time is:                      Tue May 24 13:55:23 2016 EDT
Firmware Updates (0x02):            1 Slot
Optional Admin Commands (0x0006):   Format Frmw_DL
Optional NVM Commands (0x0006):     Wr_Unc DS_Mngmt
Maximum Data Transfer Size:         32 Pages

Would it be somehow possible to alias nvd0 to nvme0?

[Alex Samorukov]

Hi, i don't think that such alias needs to be done:

1. It is possible to have nvme device without nvd nodes exported. E.g. if no nvd driver loaded or if device does not export any usable namespace.
2. On system level only /dev/nvme* supports corresponding ioctl-s
3. I would like to keep syntax compatible with windows/linux versions were it is /dev/nvme* only.

As quick workaround i will just add warning "Please use /dev/nvme* syntax" if user will try o use /dev/nvd*.

[Christian Franke]

Possibly related ticket from FreeNAS bug tracker: ​https://bugs.pcbsd.org/issues/15534

[Alex Samorukov]

Hint added in r4602

[Christian Franke]

Milestone renamed