Analyze errors from llvm scan-build

[Alex Samorukov]

I tried to run clang scan-build tool and it ​produced a report. It seems that at least some of the warnings are real.

[Christian Franke]

5 of 6 fixed in r4206, r4207, r4208, r4209.

1: cosmetic (r4208)
2: cosmetic (r4207)
3: longstanding crash bug in smartd.conf parser (r4206)
4: harmless bug (r4209)
5: false positive (no workaround for now)
6: harmless bug (r4207)

[Alex Samorukov]

btw, as far as i could see from the logic 5 could happens if we have ATA controller w/o any devices on it (n wont increment). So i think something like that should be better:

os_freebsd.cpp

@@ -1596 +1596 @@
         n++;
       };
     };
-  };
-  mp = (char **)reallocf(mp,n*(sizeof (char*))); // shrink to correct size
+  };
+  if (n != 0) {
+    mp = (char **)reallocf(mp,n*(sizeof (char*))); // shrink to correct size
+  }
+  else {
+    goto end;
+  }
   if (mp == NULL && n > 0 ) { // reallocf never fail for size=0, but may return NULL
     serrno=errno;
     pout("Out of memory constructing scan device list (on line %d)\n", __LINE__);

[Christian Franke]

The n > 0 check and comment following the reallocf() are no longer needed then. Probably better:

os_freebsd.cpp

@@ -1597 +1597 @@
       };
     };
   };
+  if (n <= 0)
+    goto end;
   mp = (char **)reallocf(mp,n*(sizeof (char*))); // shrink to correct size
-  if (mp == NULL && n > 0 ) { // reallocf never fail for size=0, but may return NULL
+  if (mp == NULL) {
     serrno=errno;
     pout("Out of memory constructing scan device list (on line %d)\n", __LINE__);
     n = -1;

(blind patch, I don't have a FreeBSD VM available here ...)

[Alex Samorukov]

5 fixed in r4211