improvements for the systemd service file

[cadhalpun]

I think the service file for smartmontools could be improved:

• Add a reference to the documentation in the [Unit] section, e.g.:

Documentation=man:smartd(8) man:smartd.conf(5)

• The 'EnvironmentFile=-/usr/local/etc/sysconfig/smartmontools' line should not be in the unit file, as that contains only three configuration options, two of which (enable_smart, start_smartd) are completely ignored by the service file and the third (smartd_opts) is only for additional command line options, that should better be changed in the service file itself.

The second point has already been requested in ticket 194, but was not implemented. I think having the 'EnvironmentFile=' line in the service file is more confusing than helpful, so please consider removing it.

​http://sourceforge.net/ticket/194

[cadhalpun]

patch to improve systemd service file

[Christian Franke]

• The 'EnvironmentFile=-/usr/local/etc/sysconfig/smartmontools' line should not be in the unit file, ... (smartd_opts) is only for additional command line options, that should better be changed in the service file itself.

Not in general. Packagers might want a R/O service file with reads smart_opts from a separate R/W file.
I will add a --with-systemdenvfile=[FILE|no] configure option to handle both use cases.

[Christian Franke]

r3875, r3876. Please try --without-systemdenvfile configure option.