Opened 6 years ago

Closed 6 years ago

#290 closed enhancement (worksforme)

New attribute format raw8/raw32

Reported by: Dan Lukes Owned by: Christian Franke
Priority: minor Milestone:
Component: all Version:
Keywords: Cc:

Description

Such format is used in Intel SSD (at least S3500 and 520, see Intel's specification) Thermal Throtle Status attribute. The first byte is the throttle status reported as integer percentage. The next four bytes number is number of times the thermal throttle has activated over lifetime.

Patch is attached. Although I have commiters right, I would like ask someone more skilled to review and apply the patch.

Attachments (1)

patch-raw8_raw32 (1.9 KB) - added by Dan Lukes 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Dan Lukes

Attachment: patch-raw8_raw32 added

comment:1 Changed 6 years ago by Christian Franke

Owner: changed from somebody to Christian Franke
Status: newaccepted

comment:2 Changed 6 years ago by Christian Franke

Milestone: Release 6.3

The patch looks good.

But using this new format in drivedb.h would break its backward compatibility. Fortunately the existing format raw24/raw32 is a superset. It prints more bytes in different order. This could be changed by the BYTEORDER parameter.
Please try

-v 234,raw24/raw32:04321,Thermal_Throttle

This should be backward compatible with drivedb.h branches >= 5.40.

The new format is not needed if this works. Ticket could be set to worksforme then.

comment:3 Changed 6 years ago by Dan Lukes

Resolution: worksforme
Status: acceptedclosed

Well, thermal throttle never occurred on my drive, so all bytes are zero. But it can be tested on any other attribute, I did it and it seems to work. So you are true, new format is not needed.

I will update definition of attribute 234 in drivedh.h according your advice for affected Intel's disc.

Thank you.

Note: See TracTickets for help on using tickets.