Opened 11 years ago
Closed 11 years ago
#290 closed enhancement (worksforme)
New attribute format raw8/raw32
| Reported by: | Dan Lukes | Owned by: | Christian Franke |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | all | Version: | |
| Keywords: | Cc: |
Description
Such format is used in Intel SSD (at least S3500 and 520, see Intel's specification) Thermal Throtle Status attribute. The first byte is the throttle status reported as integer percentage. The next four bytes number is number of times the thermal throttle has activated over lifetime.
Patch is attached. Although I have commiters right, I would like ask someone more skilled to review and apply the patch.
Attachments (1)
Change History (4)
by , 11 years ago
| Attachment: | patch-raw8_raw32 added |
|---|
comment:1 by , 11 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → accepted |
comment:2 by , 11 years ago
| Milestone: | Release 6.3 |
|---|
comment:3 by , 11 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | accepted → closed |
Well, thermal throttle never occurred on my drive, so all bytes are zero. But it can be tested on any other attribute, I did it and it seems to work. So you are true, new format is not needed.
I will update definition of attribute 234 in drivedh.h according your advice for affected Intel's disc.
Thank you.
The patch looks good.
But using this new format in drivedb.h would break its backward compatibility. Fortunately the existing format
raw24/raw32is a superset. It prints more bytes in different order. This could be changed by the BYTEORDER parameter.Please try
This should be backward compatible with drivedb.h branches >= 5.40.
The new format is not needed if this works. Ticket could be set to worksforme then.