Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#1959 closed defect (fixed)

Broken smart_drivedb.h on svn (7.2 branch only)

Reported by: alt36 Owned by:
Priority: major Milestone: Release 8.0
Component: drivedb Version:
Keywords: Cc:

Description

Attempts to update drivedb from the default 'svn' source currently fail:

/usr/sbin/update-smart-drivedb: /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible

Comparing the downloaded .error file to the the previous version, I note the removal of "*/" to close a comment:

# diff -u /var/lib/smartmontools/drivedb/drivedb.h /var/lib/smartmontools/drivedb/drivedb.h.error
--- /var/lib/smartmontools/drivedb/drivedb.h    2025-06-16 11:34:11.701789880 +0100
+++ /var/lib/smartmontools/drivedb/drivedb.h.error      2025-06-16 11:54:53.267945471 +0100
@@ -67,8 +67,7 @@

 /*
 const drive_settings builtin_knowndrives[] = {
- */
-  { "VERSION: 7.2/5706 2025-04-27 16:54:06 $Id$",
+  { "VERSION: 7.2/5761 2025-06-15 11:51:35 +0000 5240566eef62",
     "-", "-",
     "Version information",
     ""

If I specify e.g. "-u github" to use a different download source, the drivedb.h file is currently OK.

Change History (3)

comment:1 by Christian Franke, 9 months ago

Milestone: Release 8.0
Priority: minormajor

Thanks for catching! Accidental deletion on 7.2 branch only. Will be fixed soon.

-u github still points to a branch of the old R/O mirror and no longer provides new versions.

comment:2 by Christian Franke, 9 months ago

Resolution: fixed
Status: newclosed

Fixed in r5720 ([4c17a5562b]). Thanks!

comment:3 by Christian Franke, 9 months ago

Summary: Broken smart_drivedb.h on svnBroken smart_drivedb.h on svn (7.2 branch only)
Note: See TracTickets for help on using tickets.