Opened 10 years ago

Closed 9 years ago

#18 closed task (fixed)

os_freebsd.cpp - convert ATA interfaces from *::ata_command_interface to the ata_pass_through

Reported by: Alex Samorukov Owned by: somebody
Priority: major Milestone: Release 5.40
Component: all Version: 5.39.1
Keywords: FreeBSD ata_pass_trough 48bit Cc:

Description

Currently os_freebsd.cpp is still using old ata_command_interface style for all ata classes. Migration to the ata_pass_through will allow to avoid unneeded code duplication and problems related to this. Also it will give an abilty to implement multisector reading and 48bit i/o.

Change History (5)

comment:1 Changed 10 years ago by Christian Franke

Version: 5.39

comment:2 Changed 10 years ago by Dan Lukes

Keywords: ata_pass_trough 48bit added

freebsd_ata_device rebased from ata_device_with_command_set to ata_device.
freebsd_ata_device::ata_pass_through() implemented

multisector reading and 48bit io are implemented but NOT TESTED so much.

Especially conversion of smartmontool's format of lba
and FreeBSD's one may not be correct.

It is ad-hoc tested on hardware I have and it work,
but it require more testing

See also

https://sourceforge.net/changeset/3011

comment:3 Changed 9 years ago by Christian Franke

This was probably fixed with r3011, r3017, r3066. If this is the case please close this ticket.

comment:4 Changed 9 years ago by Dan Lukes

Version: 5.395.39.1

Escalade and HighPoint? is not converted yet. It's still based on ata_device_with_command_set. But I have no such hardware.

comment:5 Changed 9 years ago by Christian Franke

Resolution: fixed
Status: newclosed

r3011, r3017, r3066.

Created new tickets #70 and #71 for controller-specific code.

Note: See TracTickets for help on using tickets.