Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#154 closed defect (fixed)

os_freebsd.cpp: Kernel version check does not work on DragonFly

Reported by: Christian Franke Owned by: Alex Samorukov
Priority: major Milestone: Release 5.42
Component: all Version: 5.40
Keywords: dragonfly Cc:

Description

Checks for __DragonFly__ should be added to the checks for __FreeBSD_version.

Original report: http://gnats.netbsd.org/40628

Change History (4)

comment:1 Changed 8 years ago by Christian Franke

Milestone: Release 5.41Release 5.42

comment:2 Changed 8 years ago by Alex Samorukov

Owner: changed from somebody to Alex Samorukov
Status: newaccepted

I`ll try to work on this

comment:3 Changed 8 years ago by Alex Samorukov

Resolution: fixed
Status: acceptedclosed

Bug is fixed. What was done:

1) I found that problematic code was related to ATA code and cam_error_print function. Both this functions are present in the current dfbsd. FreeBSD5 is unsupported for a very long time, so i removed this #ifdef blocks from the sources. I tested compilation on DragonFly? v2.10.1.1 and it works fine.
2) There is also block about atacam support. DragonFly? 2.10 do not include atacam, so this block is not included.
3) FREEBSDVER in dfbsd case is bogus. Best of all is to rewrite this defines to something like HAVE_ATACAM, HAVE_LIBUSB1, HAVE_LIBUSB2 and define them on configure stage. But currently everything is working fine and i have no time to do this.

comment:4 Changed 8 years ago by Christian Franke

Note: See TracTickets for help on using tickets.