Changes between Version 1 and Version 2 of Ticket #1467, comment 9


Ignore:
Timestamp:
Apr 7, 2021, 8:46:21 AM (15 months ago)
Author:
Alex Samorukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1467, comment 9

    v1 v2  
    1 Thank you for testing. It should not break real scsi. There is a way to be even more strict and do SAT check ONLY when sc_bus != SCSI, but i think it is overkill + device is not yet open when we doing `return get_scsi_device`. Also checked with netbsd - it should not be relevant as NetBSD always adds AHCI devices as wd* and not sd*. We also doing sat check by default on Linux/BSD, so that should not harm.
     1Thank you for testing. It should not break real scsi. There is a way to be even more strict and do SAT check ONLY when sc_bus != SCSI, but i think it is overkill + device is not yet open when we doing `return get_scsi_device`. Also checked with netbsd - it should not be relevant as NetBSD always adds AHCI devices as wd* and not sd*. We also doing sat check by default on Linux/FreeBSD, so that should not harm.