Timeout too short for some devices under openBSD

[Martin Ziemer]

Under OpenBSD some timeouts are too short because of a needed conversion to seconds.

The problem can be fixed for OpenBSD in scsiata.cpp in line 367 by applying a multiplier of 1000 as used in os_openbsd.cpp in line 173. (But i guess it would break other Operating Systems!)

I dont know, where to apply this multiplier without breaking other Operating Systems! It would be great, if someone finds the right spot to correct this.

[Christian Franke]

Please test this patch:

os_openbsd.cpp

@@ -266 +266 @@
   sc.databuf = (char *)iop->dxferp;
   sc.datalen = iop->dxfer_len;
   sc.senselen = iop->max_sense_len;
-  sc.timeout = iop->timeout == 0 ? 60000 : iop->timeout;       /* XXX */
+  sc.timeout = (iop->timeout == 0 ? 60 : iop->timeout) * 1000;
   sc.flags =
     (iop->dxfer_dir == DXFER_NONE ? SCCMD_READ :
     (iop->dxfer_dir == DXFER_FROM_DEVICE ? SCCMD_READ : SCCMD_WRITE));

[Martin Ziemer]

This patch works: The "atascsi_passthru_done, timeout"-messages go away in smartd as well as smartctl.

[Christian Franke]

Thanks. Feel free to provide it as a patch.

[Christian Franke]

Applied in r5214, thanks.