Opened 23 months ago
Closed 23 months ago
#1466 closed defect (fixed)
Timeout too short for some devices under openBSD
Reported by: | Martin Ziemer | Owned by: | Christian Franke |
---|---|---|---|
Priority: | major | Milestone: | Release 7.3 |
Component: | all | Version: | |
Keywords: | openbsd scsi | Cc: |
Description
Under OpenBSD some timeouts are too short because of a needed conversion to seconds.
The problem can be fixed for OpenBSD in scsiata.cpp in line 367 by applying a multiplier of 1000 as used in os_openbsd.cpp in line 173. (But i guess it would break other Operating Systems!)
I dont know, where to apply this multiplier without breaking other Operating Systems! It would be great, if someone finds the right spot to correct this.
Attachments (1)
Change History (6)
comment:1 Changed 23 months ago by
Keywords: | openbsd scsi added; OpenBSD removed |
---|---|
Milestone: | → undecided |
Priority: | minor → major |
comment:2 Changed 23 months ago by
This patch works: The "atascsi_passthru_done, timeout"-messages go away in smartd as well as smartctl.
comment:3 Changed 23 months ago by
Milestone: | undecided → Release 7.3 |
---|
Thanks. Feel free to provide it as a patch.
Changed 23 months ago by
Attachment: | timeout.patch added |
---|
comment:4 Changed 23 months ago by
Owner: | set to Christian Franke |
---|---|
Status: | new → accepted |
comment:5 Changed 23 months ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Applied in r5214, thanks.
Note: See
TracTickets for help on using
tickets.
Please test this patch:
os_openbsd.cpp
iop->timeout == 0 ? 60000 : iop->timeout; /* XXX */