Opened 3 months ago
Closed 3 months ago
#1436 closed enhancement (fixed)
Always add timestamp to json
| Reported by: | Michael Schneider | Owned by: | Christian Franke |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 7.3 |
| Component: | smartctl | Version: | |
| Keywords: | Cc: |
Description
json version, smartctl information, messages and exist status is always added to json but the timestamp of the activity isn't there. Having a timestamp available in every json output will simplify the communication with the interface.
The suggested solution is to move the population of the timestamp into jglb from ataprint.cpp, scsiprint.cpp and nvmeprint.cpp into main.
A patch is attached but requires testing.
Attachments (1)
Change History (5)
Changed 3 months ago by
| Attachment: | alwaystimestamp.patch added |
|---|
comment:1 Changed 3 months ago by
Corrected version:
json version, smartctl information, messages and exist status is always added to json but the timestamp of the activity isn't there. Having a timestamp available in every json output will simplify the communication with the interface.
The suggested solution is to move the timestamp from ataprint.cpp, scsiprint.cpp and nvmeprint.cpp into main.
A patch is attached but requires testing.
comment:3 Changed 3 months ago by
| Owner: | set to Christian Franke |
|---|---|
| Status: | new → accepted |
I will use a slightly different approach which makes sure that timestamps in a --json=o output always match.
Patch based on #5199