#1376 closed patch (fixed)

Add SSSTC ER2-GD/CD to drive db

Reported by: kobyou Owned by: Christian Franke
Priority: minor Milestone: Release 7.2
Component: drivedb Version: 7.1
Keywords: ssd Cc:

Description

LITEON SSD rename to SSSTC SSD。
but There is not yet in smartmontools drive db for SSSTC SSD,Please help to add it,thanks!

Model name:
SSSTC ER2-GD240
SSSTC ER2-GD480
SSSTC ER2-CD240
SSSTC ER2-CD480
SSSTC ER2-CD960
SSSTC ER2-CD1920

Need to add smartid item:
"-v 170,raw48,Available_Reserve_Space,SSD "
"-v 171,raw48,Program_Fail_Count_Total,SSD "
"-v 172,raw48,Erase_Fail_Count_Total,SSD "
"-v 173,raw48,Average_PE_Count,SSD "
"-v 174,raw48,Unexpected_Power_Loss_Count,SSD "
"-v 202,raw48,Percentage_Lifetime_Remaining,SSD "
"-v 210,raw48,Raid_Success_Recovered_Count,SSD "
"-v 234,raw48,Thermal_Throttle_Status,SSD "
"-v 243,raw48,NAND_GB_Written,SSD "

Attachments (8)

smartctl-SSSTC ER2.txt (7.5 KB) - added by kobyou 13 months ago.
smartctl-SSSTC ER2
drivedb_modify.h (208.3 KB) - added by kobyou 13 months ago.
after modify drivedb
drivedb.h (207.7 KB) - added by kobyou 13 months ago.
original drivedb
diff.png (536.3 KB) - added by kobyou 13 months ago.
diff
drivedb_modify1.h (208.2 KB) - added by kobyou 13 months ago.
add ssstc model to drivedb
diff_report.txt (979 bytes) - added by kobyou 13 months ago.
diff report
drivedb_modify2.h (208.3 KB) - added by kobyou 13 months ago.
add modify SMART ID 175 & 183
diff.txt (1.0 KB) - added by kobyou 13 months ago.
diff report

Download all attachments as: .zip

Change History (20)

Changed 13 months ago by kobyou

Attachment: smartctl-SSSTC ER2.txt added

smartctl-SSSTC ER2

comment:1 Changed 13 months ago by Christian Franke

Cc: Christian Franke removed
Keywords: ssd added; SSSTC removed
Milestone: Release 7.2undecided
Priority: criticalminor
Type: defectenhancement

Notes for future ticket submissions:

  • Please do not set a milestone.
  • Drivedb enhancement requests are never critical. You could add custom entries locally, see -B option on smartctl man page.

comment:2 Changed 13 months ago by Christian Franke

Summary: Add SSSTC SSD driver to drive dbAdd SSSTC ER2-GD/CD to drive db

comment:3 Changed 13 months ago by Christian Franke

Which SSD controller do these drives use?

comment:4 Changed 13 months ago by kobyou

SSD controller : Marvel DEAN 2.1

comment:5 in reply to:  description Changed 13 months ago by Christian Franke

LITEON SSD rename to SSSTC SSD。
...
Model name:
SSSTC ER2-GD240
SSSTC ER2-GD480
SSSTC ER2-CD240
SSSTC ER2-CD480
SSSTC ER2-CD960
SSSTC ER2-CD1920

Which were the former LITEON model names?

comment:6 Changed 13 months ago by kobyou

it don't use the name of Liteon model name anymore, Has been renamed SSSTC.

comment:7 Changed 13 months ago by Christian Franke

Milestone: undecidedunscheduled

Changed 13 months ago by kobyou

Attachment: drivedb_modify.h added

after modify drivedb

Changed 13 months ago by kobyou

Attachment: drivedb.h added

original drivedb

Changed 13 months ago by kobyou

Attachment: diff.png added

diff

comment:8 Changed 13 months ago by Christian Franke

Type: enhancementpatch

Issues:

  • TESTING IS MANDATORY. The regexp looks good but the entry contains syntax errors:
    $ smartctl -B ./drivedb_modify.h -P showall 'SSSTC ER2-GD480'
    Drive found in smartmontools Database.  Drive identity strings:
    MODEL:              SSSTC ER2-GD480
    FIRMWARE:           (any)
    match smartmontools Drive Database entry:
    MODEL REGEXP:       SSSTC ER2-(GD|CD)(240|480|960|1920)
    FIRMWARE REGEXP:    .*
    MODEL FAMILY:       SSSTC ER2 GD/CD Series SSDs
    ATTRIBUTE OPTIONS:  170 Available_Reserve_Space
                        171 Program_Fail_Count_Total
              Error: Attribute name too long ------^
                        172 Erase_Fail_Count_Total
                        173 Average_PE_Count
                        174 Unexpected_Power_Loss_Count
              Error: Attribute name too long ------^
                        202 Percentage_Lifetime_Remaining
              Error: Attribute name too long ------^
                        210 Raid_Success_Recovered_Count
              Error: Attribute name too long ------^
                        234 Thermal_Throttle_Status
                        243 NAND_GB_Written
    
  • -v options with are already covered by the DEFAULT entry should be present and commented-out (see various other SSD entries for examples). This documents which attributes are supported.
  • Provide the new entry as a patch (svn diff or diff -u outputs) instead of a full drivedb.h file.
  • Screenshots are useless as patch tools only understand plaintext :-)

Note that we may modify entries later to unify attribute naming or include other drive series which have similar attribute sets (e.g. former LITEON models in this case).

Changed 13 months ago by kobyou

Attachment: drivedb_modify1.h added

add ssstc model to drivedb

Changed 13 months ago by kobyou

Attachment: diff_report.txt added

diff report

comment:9 Changed 13 months ago by Christian Franke

Milestone: unscheduledRelease 7.2

Changed 13 months ago by kobyou

Attachment: drivedb_modify2.h added

add modify SMART ID 175 & 183

Changed 13 months ago by kobyou

Attachment: diff.txt added

diff report

comment:10 Changed 12 months ago by Christian Franke

These are present in the patch but missing in the above output from SSSTC ER2-GD480 with Firmware E4N2302:

+    "-v 210,raw48,Raid_Success_Recover_Ct "
+    "-v 234,raw48,Thermal_Throttle_Status "

Please provide a sample output from a device which provides these attributes.

comment:11 Changed 12 months ago by Christian Franke

Owner: set to Christian Franke
Status: newaccepted

comment:12 Changed 12 months ago by Christian Franke

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.