Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#1314 closed enhancement (fixed)

Add support for JMS56x RAID

Reported by: elbandi Owned by: Christian Franke
Priority: minor Milestone: Release 7.2
Component: all Version: 7.1
Keywords: jmicron jms56x Cc:

Description

I have this device: https://www.speeddragon.com/index.php?controller=Default&action=ProductInfo&Id=590

Actually, it'a a clone from this: https://www.sybausa.com/index.php?route=product/product&path=64_148&product_id=850

It has a JMicron JMS562 chip. If i modify some parameters in dev_jmb39x_raid, it works.

SCRAMLED_CMD: 0x197b0562
CRC: 0xde10952b

Attachments (3)

logicalvolume.txt (1.3 KB) - added by elbandi 13 months ago.
result from query the raid volume
debug.txt (118.7 KB) - added by elbandi 13 months ago.
query device with modified code
0001-Change-dev_jmb39x_raid-to-JMS56x.patch (1.1 KB) - added by elbandi 13 months ago.

Download all attachments as: .zip

Change History (12)

Changed 13 months ago by elbandi

Attachment: logicalvolume.txt added

result from query the raid volume

Changed 13 months ago by elbandi

Attachment: debug.txt added

query device with modified code

comment:1 Changed 13 months ago by Christian Franke

Milestone: undecided

... If i modify some parameters in dev_jmb39x_raid, it works.

Please provide these modifications as a patch file.

Related: tickets #705, #1283, #1290.

comment:2 Changed 13 months ago by elbandi

I just changed the two parameters, but thats breaks the jmb39x support, so not good for long time. I think this jmicron device support need a refactor for a common support: rename the dev_jmb39x to something dev_jmicron_raid.cpp, handle better the different chips and the chips variants. like:
-d jmicron,chiptype[jmb39x|jms56x|xxx],variantid

it this idea is good, i can make this changes.

Version 0, edited 13 months ago by elbandi (next)

comment:3 Changed 13 months ago by Christian Franke

Of course your changes would break existing support. So please provide you changes as a patch file to document it cleanly. Of course, the patch will not be applied.

I leave any refactoring for later as more enhancements (#1290) are expected.

Changed 13 months ago by elbandi

comment:4 Changed 13 months ago by Christian Franke

Milestone: undecidedRelease 7.2
Summary: Add support for JMS56x seriesAdd support for JMS56x RAID

Thanks. I will add another (possibly preliminary) option to select this variant.

Any refactoring and unifying of option syntax will done later, possibly close to next release.

comment:5 Changed 13 months ago by Christian Franke

Owner: set to Christian Franke
Status: newaccepted

comment:6 Changed 13 months ago by Christian Franke

Resolution: fixed
Status: acceptedclosed

comment:7 Changed 13 months ago by Christian Franke

Please test smartctl -d jms56x,N ... with a build from current SVN trunk.

Source tarballs and various binaries are available at https://builds.smartmontools.org/.

comment:8 Changed 12 months ago by Christian Franke

Any test results so far?

comment:9 Changed 12 months ago by elbandi

it works for me.

Note: See TracTickets for help on using tickets.