Opened 6 years ago

Closed 6 years ago

#1080 closed defect (wontfix)

smartd.service: Use Type=forking to wait for successful initialisation

Reported by: Christian Franke Owned by:
Priority: minor Milestone:
Component: smartd Version: 6.6
Keywords: linux Cc:

Description

From ​Debian Bug 865912:

Forking to the background (Type=forking) is the recommended way to signal to systemd that a daemon has initialized successfully and is ready for operation; at least for daemons without explicit systemd
support (Type=notify).

In this particular case, "systemd restart smartd" will give immediate feedback of a failure if the user makes a mistake in /etc/smartd.conf.

Proposed patch:

  • smartd.service.in

     
    66[Service]
     7Type=forking
    78EnvironmentFile=-/usr/local/etc/sysconfig/smartmontools
    8 ExecStart=/usr/local/sbin/smartd -n $smartd_opts
     9ExecStart=/usr/local/sbin/smartd $smartd_opts
    910ExecReload=/bin/kill -HUP $MAINPID

Change History (3)

comment:1 by Christian Franke, 6 years ago

Keywords: linux added

comment:2 by Christian Franke, 6 years ago

If Type=forking is used, ExecReload=/bin/kill -HUP $MAINPID requires PIDFile=... and smartd option -p ....

See also ticket #1081.

comment:3 by Christian Franke, 6 years ago

Milestone: undecided
Resolution: → wontfix
Status: new → closed

No longer needed as Type=notify is now supported, see ticket #1081.

Note: See TracTickets for help on using tickets.