Changes between Version 1 and Version 2 of Ticket #1079, comment 8


Ignore:
Timestamp:
Aug 30, 2018, 10:54:39 AM (3 years ago)
Author:
Rick Chen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1079, comment 8

    v1 v2  
    22> Patch rejected because it apparently renames '''all''' `pout` to `jout`. Please rename only those `pout` where corresponding JSON output is added by the patch. Please reread the related comments in [source:/trunk/smartmontools/smartctl.cpp smartctl.cpp]. Read the '''-j, --json[=giosu]''' section on [source:/trunk/smartmontools/smartctl.8.in smartctl man page]. Test the effect of `--json=iu` with and without your changes.
    33
    4 Sorry, I understand your advise. I has corrected the path and attached the file "patch_scsiprint_v1.01.2.diff". Please help me to review it.
     4Sorry, I understand your advise. I has corrected the patch and attached the file "patch_scsiprint_v1.01.2.diff". Please help me to review it.
    55Thanks.