Forwarded from: ​https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893657

(Issue (1) described bellow may not apply to upstream smartmontools, as /etc/smartmontools/run.d/10mail seems to be a Debian-specific file... but at least issue (2) should apply to upstream smartmontools as well.)

Hi.

I've stumbled over the following issues in smartd:

At first I had bascally the following smartd.conf:

DEVICESCAN -d auto -d removable -n standby,4 -a -m root,mylocaluser,my@email.com -M exec /usr/share/smartmontools/smartd-runner

In order to test it, I've added -M test.

Now on restart, only root got mail, and the postfix logs didn't even show any tries for mylocaluser and my@….

I've added -M once, as I assumed the support for comma-separated multiple addresses as explained in the smartd.conf manpage for -m, may just not work with -M-exec-invoked /etc/smartmontools/run.d/10mail but only with -M once, -M daily or -M diminishing (and that this might be some other mail sender than /etc/smartmontools/run.d/10mail - which it actually seems to be).

Interestingly, it still didn't work. Only if I removed -M exec... I got mail sent to all three recipients.

So I think there are two issues here: 1) /etc/smartmontools/run.d/10mail, which seems to be used per default by debian (as there is no -M once or so) should support multiple addresses in -m. It's likely not obvious to the user that there are two methods of sending warning mails, and it should just work as one would naively assume by reading the documentation of -m.

2) In contrast to what the manpage claims, it seems that if -M exec is in place, -M once/etc. are not executed as well.

IMO both are severity=important, as they may prevent information about failing drives being passed on.

Cheers, Chris.

> sudo /usr/sbin/smartctl -V
Copyright (C) 2002-10 by Bruce Allen, http://smartmontools.sourceforge.net

smartctl comes with ABSOLUTELY NO WARRANTY. This is free
software, and you are welcome to redistribute it under
the terms of the GNU General Public License Version 2.
See http://www.gnu.org for further details.


> sudo /usr/sbin/smartctl --version
Copyright (C) 2002-10 by Bruce Allen, http://smartmontools.sourceforge.net

smartctl comes with ABSOLUTELY NO WARRANTY. This is free
software, and you are welcome to redistribute it under
the terms of the GNU General Public License Version 2.
See http://www.gnu.org for further details.

Shouldn't smartctl report its version number (smartmontools-5.40 2010-10-16 r3189 according to the man page)?

Setup:

$ ls -l /dev/disk/by-id/wwn-0x5000xxxx
lrwxrwxrwx 9 root 2020-10-31 15:15 /dev/disk/by-id/wwn-0x5000xxxx -> ../../sda
$ cat /etc/smartd.conf
/dev/disk/by-id/wwn-0x5000xxxx -d ignore
DEVICESCAN -a

Expected result:

Device with specified id is ignored.

Actual result:

Device (/dev/sda in this example) is not ignored.

Analysis:

This issue seems to be similar to #313.

Duplicate detection (is_duplicate_dev_idinfo) relies on populated dev_idinfo, and that is done in ATADeviceScan. But "-d ignore" bypasses any scanning altogether, thus duplicate detection is unable to deduce that /dev/sda and /dev/disk/by-id/wwn-0x5000xxxx are actually the same device.

There is another duplicate detection function (is_duplicate_device), but it relies on dev_names being exactly equal. I attempted to fix the issue by checking if dev_name is a symbolic link and resolving the link to actual file in such cases - seems to work correctly.

Please find attached for your consideration a patch that implements symlink resolution for device names (apply with patch --input=resolve_device_symlinks.patch in source directory).