smartmontools fails to build on osx after r4067, see error report below:

[...output skipped]
config.status: creating update-smart-drivedb
chmod +x update-smart-drivedb
/bin/sh ./config.status --file=smartd_warning.sh
config.status: creating smartd_warning.sh
chmod +x smartd_warning.sh
  cat ./smartd.conf.5.in | $(MAN_FILTER) > smartd.conf.5
/bin/sh: -c: line 0: syntax error near unexpected token `|'
/bin/sh: -c: line 0: `cat ./smartd.conf.5.in | sed -e 's|CURRENT_SVN_VERSION|smartmontools-6.4|g' -e "s|CURRENT_SVN_DATE|`sed -n 's,^.*DATE[^"]*"\([^"]*\)".*$,\1,p' svnversion.h`|g" -e "s|CURRENT_SVN_REV|`sed -n 's,^.*REV[^"]*"\([^"]*\)".*$,r\1,p' svnversion.h`|g" -e 's|/usr/local/share/man/|/usr/local/share/man/|g' -e 's|/usr/local/sbin/|/usr/local/sbin/|g' -e 's|/usr/local/etc/rc\.d/init.d/|/|g' -e 's|/usr/local/share/doc/smartmontools/examplescripts/|!exampledir!|g' -e 's|/usr/local/share/doc/smartmontools/|/usr/local/share/doc/smartmontools/|g' -e 's|!exampledir!|/usr/local/share/doc/smartmontools/examplescripts/|g' -e 's|/usr/local/etc/smartd\.conf|/usr/local/etc/smartd.conf|g' -e 's|/usr/local/etc/smart_drivedb\.h|/usr/local/etc/smart_drivedb.h|g' -e 's|/usr/local/etc/smartd_warning\.sh|/usr/local/etc/smartd_warning.sh|g' -e 's|\\fBmail\\fP|\\fBmail\\fP|g' -e 's|\\'\''mail\\'\''|\\'\''mail\\'\''|g' -e 's|/usr/bin/mail|/usr/bin/mail|g' -e 's|RELEASE_6_0_DRIVEDB|RELEASE_6_4_DRIVEDB|g' | if test -n '/usr/local/etc/smartd_warning.d'; then sed 's|/usr/local/etc/smartd_warning\.d|/usr/local/etc/smartd_warning.d|g' ; else sed '/^\.\\" %IF ENABLE_SMARTDPLUGINDIR/,/^\.\\" %ENDIF ENABLE_SMARTDPLUGINDIR/ s,^,.\\"# ,' ; fi | sed '/^\.\\" %IF ENABLE_ATTRIBUTELOG/,/^\.\\" %ENDIF ENABLE_ATTRIBUTELOG/ s,^,.\\"# ,' |  | sed "s|/usr/local/share/smartmontools/drivedb\\.h|/usr/local/share/smartmontools/drivedb.h|g" | sed '/^\.\\" %IF ENABLE_SAVESTATES/,/^\.\\" %ENDIF ENABLE_SAVESTATES/ s,^,.\\"# ,' | if test -n 'Darwin'; then sed -e 's,OS_MAN_FILTER,Darwin,g' -e '/^\.\\" %IF NOT OS .*Darwin/,/^.\\" %ENDIF NOT OS .*Darwin/ s,^,.\\"# ,' -e '/^\.\\" %IF OS .*Darwin/,/^\.\\" %ENDIF OS .*Darwin/ s,^,!!,' -e '/^\.\\" %IF OS ./,/^\.\\" %ENDIF OS ./ s,^,.\\"# ,' -e '/^!*\.\\" %IF NOT OS ./,/^!*\.\\" %ENDIF NOT OS ./ s,^,!!,' -e 's,^!!!*\.\\"! \(.*\)$,\1 \\"#,' -e 's,^!!!*,,' ; else cat; fi > smartd.conf.5'
make[1]: *** [smartd.conf.5] Error 2
make: *** [all] Error 2

Details from ports patch - ​https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215356

smartmontools: fix panic on INVARIANTS enabled kernel after r308351 in base

After r308351 commit the INVARIANTS enabled kernel gets too "eager" when checking the cam ccb flags. But the real problem was not the previous, but the smartmontools does not zeroed out the ccb on stack, and pass this dirty ccb to kernel, which is catched by an ASSERT. So fix this by filling up with 0 this ccb. This commit is similar, what's happen in r307684 in camcontrol. So this is the same followup patch in smartmontools.

​https://svnweb.freebsd.org/base?view=revision&revision=307684 ​https://svnweb.freebsd.org/base?view=revision&revision=308351

Sponsored-by: opBSD

op@opn ~> smartctl --version smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-STABLE-HBSD amd64] (local build) Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

smartctl comes with ABSOLUTELY NO WARRANTY. This is free software, and you are welcome to redistribute it under the terms of the GNU General Public License; either version 2, or (at your option) any later version. See ​http://www.gnu.org for further details.

smartmontools release 6.5 dated 2016-05-07 at 11:17:46 UTC smartmontools SVN rev 4318 dated 2016-05-07 at 11:18:20 smartmontools build host: amd64-portbld-freebsd11.0 smartmontools build with: C++98, GCC 4.2.1 Compatible FreeBSD Clang 3.8.0 (tags/RELEASE_380/final 262564) smartmontools configure arguments: '--disable-dependency-tracking' '--enable-sample' '--with-nvme-devicescan=yes' '--with-initscriptdir=/usr/local/etc/rc.d' '--prefix=/usr/local' '--localstatedir=/var' '--mandir=/usr/local/man' '--disable-silent-rules' '--infodir=/usr/local/info/' '--build=amd64-portbld-freebsd11.0' 'build_alias=amd64-portbld-freebsd11.0' 'CXX=c++' 'CXXFLAGS=-O2 -pipe -pipe -DHARDENEDBSD -fstack-protector -fno-strict-aliasing -DHARDENEDBSD' 'LDFLAGS= -fstack-protector' 'LIBS=' 'CPPFLAGS=' 'CC=cc' 'CFLAGS=-O2 -pipe -pipe -DHARDENEDBSD -fstack-protector -fno-strict-aliasing'

the configure stackprotection detection

​https://github.com/Freetz-NG/freetz-ng/issues/186#issuecomment-775178338

might wrongly detect support where there is none.

looks like a change as described here

​https://github.com/apple/cups/issues/3198

would prevent that.

thanks!.. ede