Custom Query (1566 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (436 - 438 of 1566)

Ticket Resolution Summary Owner Reporter
#915 fixed Clang generates warnings on compilation "taking address of packed member" on the atacmds.cpp Christian Franke Alex Samorukov
Description
atacmds.cpp:1004:12: warning: taking address of packed member 'extend_test_completion_time_w' of class or structure 'ata_smart_values' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&data->extend_test_completion_time_w);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
atacmds.cpp:1091:12: warning: taking address of packed member 'log_desc_index' of class or structure 'ata_smart_extselftestlog' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&log->log_desc_index);
           ^~~~~~~~~~~~~~~~~~~
atacmds.cpp:1198:12: warning: taking address of packed member 'logversion' of class or structure 'ata_smart_log_directory' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&data->logversion);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:1521:12: warning: taking address of packed member 'device_error_count' of class or structure 'ata_smart_exterrlog' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&log->device_error_count);
           ^~~~~~~~~~~~~~~~~~~~~~~
atacmds.cpp:1522:12: warning: taking address of packed member 'error_log_index' of class or structure 'ata_smart_exterrlog' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&log->error_log_index);
           ^~~~~~~~~~~~~~~~~~~~
atacmds.cpp:2260:12: warning: taking address of packed member 'format_version' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->format_version);
           ^~~~~~~~~~~~~~~~~~~
atacmds.cpp:2261:12: warning: taking address of packed member 'sct_version' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->sct_version);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2262:12: warning: taking address of packed member 'sct_spec' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->sct_spec);
           ^~~~~~~~~~~~~
atacmds.cpp:2263:12: warning: taking address of packed member 'ext_status_code' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->ext_status_code);
           ^~~~~~~~~~~~~~~~~~~~
atacmds.cpp:2264:12: warning: taking address of packed member 'action_code' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->action_code);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2265:12: warning: taking address of packed member 'function_code' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->function_code);
           ^~~~~~~~~~~~~~~~~~
atacmds.cpp:2266:12: warning: taking address of packed member 'over_limit_count' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->over_limit_count);
           ^~~~~~~~~~~~~~~~~~~~~
atacmds.cpp:2267:12: warning: taking address of packed member 'under_limit_count' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->under_limit_count);
           ^~~~~~~~~~~~~~~~~~~~~~
atacmds.cpp:2268:12: warning: taking address of packed member 'smart_status' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->smart_status);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2269:12: warning: taking address of packed member 'min_erc_time' of class or structure 'ata_sct_status_response' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&sts->min_erc_time);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2302:12: warning: taking address of packed member 'action_code' of class or structure 'ata_sct_data_table_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.action_code);
           ^~~~~~~~~~~~~~~
atacmds.cpp:2303:12: warning: taking address of packed member 'function_code' of class or structure 'ata_sct_data_table_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.function_code);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2304:12: warning: taking address of packed member 'table_id' of class or structure 'ata_sct_data_table_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.table_id);
           ^~~~~~~~~~~~
atacmds.cpp:2332:12: warning: taking address of packed member 'format_version' of class or structure 'ata_sct_temperature_history_table' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&tmh->format_version);
           ^~~~~~~~~~~~~~~~~~~
atacmds.cpp:2333:12: warning: taking address of packed member 'sampling_period' of class or structure 'ata_sct_temperature_history_table' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&tmh->sampling_period);
           ^~~~~~~~~~~~~~~~~~~~
atacmds.cpp:2334:12: warning: taking address of packed member 'interval' of class or structure 'ata_sct_temperature_history_table' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&tmh->interval);
           ^~~~~~~~~~~~~
atacmds.cpp:2335:12: warning: taking address of packed member 'cb_index' of class or structure 'ata_sct_temperature_history_table' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&tmh->cb_index);
           ^~~~~~~~~~~~~
atacmds.cpp:2336:12: warning: taking address of packed member 'cb_size' of class or structure 'ata_sct_temperature_history_table' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&tmh->cb_size);
           ^~~~~~~~~~~~
atacmds.cpp:2369:12: warning: taking address of packed member 'action_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.action_code);
           ^~~~~~~~~~~~~~~
atacmds.cpp:2370:12: warning: taking address of packed member 'function_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.function_code);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2371:12: warning: taking address of packed member 'feature_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.feature_code);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2372:12: warning: taking address of packed member 'state' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.state);
           ^~~~~~~~~
atacmds.cpp:2373:12: warning: taking address of packed member 'option_flags' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.option_flags);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2449:12: warning: taking address of packed member 'action_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.action_code);
           ^~~~~~~~~~~~~~~
atacmds.cpp:2450:12: warning: taking address of packed member 'function_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.function_code);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2451:12: warning: taking address of packed member 'feature_code' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.feature_code);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2452:12: warning: taking address of packed member 'state' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.state);
           ^~~~~~~~~
atacmds.cpp:2453:12: warning: taking address of packed member 'option_flags' of class or structure 'ata_sct_feature_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.option_flags);
           ^~~~~~~~~~~~~~~~
atacmds.cpp:2501:12: warning: taking address of packed member 'action_code' of class or structure 'ata_sct_error_recovery_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.action_code);
           ^~~~~~~~~~~~~~~
atacmds.cpp:2502:12: warning: taking address of packed member 'function_code' of class or structure 'ata_sct_error_recovery_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.function_code);
           ^~~~~~~~~~~~~~~~~
atacmds.cpp:2503:12: warning: taking address of packed member 'selection_code' of class or structure 'ata_sct_error_recovery_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.selection_code);
           ^~~~~~~~~~~~~~~~~~
atacmds.cpp:2504:12: warning: taking address of packed member 'time_limit' of class or structure 'ata_sct_error_recovery_control_command' may result in an unaligned pointer value
      [-Waddress-of-packed-member]
    swapx(&cmd.time_limit);
           ^~~~~~~~~~~~~~
37 warnings generated.

Clang version:

clang -v
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
#917 fixed 20s timeout is too short for large JBODs asomers
Description

Most smartctl commands have a default timeout of 20 seconds. This is sufficiently long for pretty much any disk to spin up from standby. However, many large JBODs implement staggered spinup, where they limit the number of drives that can simultaneously spin up. On such systems, it may take considerably longer for all drives to spin up. For example, I have a 96-drive JBOD where spinning up all drives takes nearly 45 seconds. The attached patch fixes smartctl for me.

#919 fixed Make Copyrights and Licenses Computer Readable: add SPDX Identifiers Christian Franke Gabriele Pohl
Description

Consider to implement License documentation according to FSFE best practice proposal: ​https://reuse.software/

BTW: The referenced page ​https://spdx.org/licenses/ lists "our" license GPL-2.0+ as obsolete.

Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.