Custom Query (1546 matches)

Some newer HPSA devices reply to basic SAT commands and provide inquiry that contains "ATA ".

It causes that sat variable in sat_device::autodetect_open() becomes true, and even if cciss is explicitly specified by smartctl -d cciss,0 -H /dev/sda it switches to sat dev/sda [cciss_disk_00] [SAT]: Device open changed type from 'sat,auto' to 'sat'

As a result, it causes failure: SMART STATUS RETURN: incomplete response, ATA output registers missing REPORT-IOCTL: Device=/dev/sda Command=SMART STATUS CHECK returned -1 errno=38 [Function not implemented]

Attached patch disables the auto-switch to "better" driver for cciss.

Note that I do not have a test report from the customer for that patch yet, but setting sat = 0 was already confirmed to prevent this bug.

Note that smart_interface::autodetect_sat_device() contains a similar code, but I am not sure whether it needs a fix as well.

SUSE licensig tool (babelworx) reported a following legal issue of smartmontools.

smartmontools is declated as GPL-2.0-or-later

But smartmontools-7.0/linux_nvme_ioctl.h is GPL-2.0 (only).

Hopefully, there is a simple fix for this problem.

New kernels contain updated linux_nvme_ioctl.h, which contain a new license: GPL-2.0 WITH Linux-syscall-note.

This is sufficient to distribute smartmontools as GPL-2.0-or-later.

When calling update-smart-drivedb from smartmontools-6.6, it always fails: /usr/sbin/update-smart-drivedb: /usr/share/smartmontools/drivedb.h.error.raw: * BAD signature *

Digging deeper into this problem by sh -x, I see: ++ gpg --quiet --no-secmem-warnin --batch --no-tty --homedir=/usr/share/smartmontools/.gnupg.12981.tmp --verify /usr/share/smartmontools/drivedb.h.new.raw.asc /usr/share/smartmontools/drivedb.h.new.raw + out='gpg: Signature made Sat Dec 28 22:44:15 2019 CET gpg: using RSA key EA74AB25721042C5 gpg: Can'\t check signature: No public key' + rc=1

There is a problem:

smartmontools-6.6 hardcodes requirement of "Smartmontools Signing Key (through 2018)". But drivedb.h.raw.asc in the branch RELEASE_6_6_DRIVEDB is signed by "Smartmontools Signing Key (through 2020)". This cannot work.

drivedb.h.raw.asc in the branch RELEASE_6_6_DRIVEDB has to use "Smartmontools Signing Key (through 2018)" forever. You have to extend validity period of this signing key, and then use that key for signing of this branch.

Similarly, once RELEASE_7_0_DRIVEDB will be created, it has to be signed by "Smartmontools Signing Key (through 2020)" forever. And if it will not be created, you will go into unfixable problems in 2021 (version 7.0 will require a different signature than a future 7.3).

In general, replacement of signing key every two years is not smart. It does not increase security, but paradoxically it decreases the security. New signing key has no trusted developer signatures, no trusted ring, so there are no way to verify that the key was created by legitimate developers.

That is why I recommend to stop creating new keys every two years. Please create a well established trusted key, and when it will be required (e. g. signature considered as weak), add a signature to it. Developers should sign this key by their private keys, so people who have them in the trust ring could immediately trust this key.

To decrease problems with future compatibility (e. g. extended key validity period, added signature), the script should update the key from the GPG network: gpg --recv-keys {key_id}

This will also ensure security, as the possibly revoked key will be refused.