Custom Query (1468 matches)

Consider to implement License documentation according to FSFE best practice proposal: ​https://reuse.software/

BTW: The referenced page ​https://spdx.org/licenses/ lists "our" license GPL-2.0+ as obsolete.

Hi there,

I tried to build the new version (6.6) on Alpine Linux, unfortenally canonicalize_file_name is not not part of musl's stdlib.

The issue was introduced in r4365:

[r4365] (108.2 kB) by chrfranke 2016-11-10 19:42:24 

os_linux.cpp: Don't detect devices behind hpsa driver as regular SCSI
devices. Suggest to use '-d cciss,N' instead.

Based on patch provided by Stanislav Brabec.

​https://sourceforge.net/p/smartmontools/code/4365/tree/trunk/smartmontools/os_linux.cpp

I have patched os_linux.cpp with the following to make it work:

--- a/os_linux.cpp
+++ b/os_linux.cpp
@@ -3176,7 +3176,7 @@
 {
   char path[128];
   snprintf(path, sizeof(path), "/sys/block/%s/device", name);
-  char * syshostpath = canonicalize_file_name(path);
+  char * syshostpath = realpath(path, NULL);
   if (!syshostpath)
     return false;

​http://man7.org/linux/man-pages/man3/canonicalize_file_name.3.html ​http://man7.org/linux/man-pages/man3/realpath.3.html

smartctl does not use the 9 bit value from the directory properly and instead reads the value 256 as zero

Steps to reproduce: smartctl -l devstat /dev/sdX on any drive that has a directory such as this

0x04       GPL     R/O    256  Device Statistics log

Expected behavior: print device statistics patched version shown

#smartctl -l devstat /dev/sdd
smartctl 6.7 2017-11-06 r4602 [x86_64-linux-4.9.16-gentoo] (local build)
Copyright (C) 2002-17, Bruce Allen, Christian Franke, www.smartmontools.org

Device Statistics (GP Log 0x04)
Page  Offset Size        Value Flags Description
0x01  =====  =               =  ===  == General Statistics (rev 1) ==
0x01  0x008  4               6  ---  Lifetime Power-On Resets
0x01  0x010  4             913  ---  Power-on Hours
....

Actual Behavior

#smartctl -l devstat /dev/sdd
smartctl 6.7 2017-11-06 r4602 [x86_64-linux-4.9.16-gentoo] (local build)
Copyright (C) 2002-17, Bruce Allen, Christian Franke, www.smartmontools.org

Device Statistics (GP/SMART Log 0x04) not supported

fix: included patch, enable already existing code to parse >8bit values in GetNumLogSectors when reading gplog devstat logs.