Custom Query (1359 matches)

I just ran the static analyser cppcheck over the source code of version 6.2

It said many things, including

[dev_areca.cpp:146] -> [dev_areca.cpp:148]: (warning) Array 'cmds[5]' accessed at index 5, which is out of bounds. Otherwise condition 'arcmsr_cmd>=5' is redundant.

Source code is

sBuf.srbioctl.ControlCode = cmds[arcmsr_cmd];

if(arcmsr_cmd >= ARCMSR_CMD_TOTAL) {

return -1;

}

Suggest move sanity check to before use.

~$ cat /etc/smartd.conf
/dev/disk/by-id/scsi-SATA_KingSpec_KDM-44VVS14413121600085 -I 194
#/dev/sdb -I 194
DEVICESCAN -a -o on -S on -n standby,q -s (S/../.././02|L/../../6/03) -W 4,40,45 -m root

referencing the disk directly allows my to exclude it from temperature monitoring, using /by-id/ fails

~$ journalctl -f

Jan 29 14:28:17 store04 smartd[1337]: smartd 6.2 2013-07-26 r3841 [i686-linux-3.11.6-4-pae] (SUSE RPM)
Jan 29 14:28:17 store04 smartd[1337]: Copyright (C) 2002-13, Bruce Allen, Christian Franke, www.smartmontools.org
Jan 29 14:28:17 store04 smartd[1337]: Opened configuration file /etc/smartd.conf
Jan 29 14:28:17 store04 smartd[1337]: Drive: /dev/disk/by-id/scsi-SATA_KingSpec_KDM-44VVS14413121600085, implied '-a' Directive o...rtd.conf
Jan 29 14:28:17 store04 smartd[1337]: Configuration file /etc/smartd.conf was parsed, found DEVICESCAN, scanning devices
Jan 29 14:28:17 store04 smartd[1337]: Device: /dev/disk/by-id/scsi-SATA_KingSpec_KDM-44VVS14413121600085, type changed from 'scsi' to 'sat'
Jan 29 14:28:17 store04 smartd[1337]: Device: /dev/disk/by-id/scsi-SATA_KingSpec_KDM-44VVS14413121600085 [SAT], opened
...
Jan 29 14:28:17 store04 smartd[1337]: Device: /dev/sdb [SAT], opened
Jan 29 14:28:17 store04 smartd[1337]: Device: /dev/sdb [SAT], KingSpec KDM-44VS.1-008GSS, S/N:VS14413121600085, FW:20131018, 7.91 GB
...
Jan 29 14:28:19 store04 smartd[1337]: Device: /dev/sdb [SAT], Temperature 54 Celsius reached critical limit of 45 Celsius (Min/Max 54/60)

Regex updates in drivesdb.h